-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the shell code in separate files #181
Conversation
✅ Deploy Preview for astonishing-pothos-5f81bd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hmm, the repo of this github action has only 9 starts. It contains only few files and doesn't affect the production but still do you want to take the risk using it in this project? 🤔 |
it doesn't seem so riskey |
Yup, I will do it. I have one question regarding it. Do you want me create the action folder inside this project or add new repo in the Hasadna github page so people could use it in future projects? This action can be helpful almost in every Frontend project. |
There are many github actions that are already available for this, feel free to choose one or create one yourself, it's up to you |
@NoamGaash I created new github action https://github.com/ArkadiK94/action-git-clean-tree and used it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great 👏
Description
Related to pr #171Why: Make the code cleaner, and not reuse code
How: Put the shell code in separate file and use this code from file when needed
screenshots
Don't need here