Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the shell code in separate files #181

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Put the shell code in separate files #181

merged 5 commits into from
Nov 10, 2023

Conversation

ArkadiK94
Copy link
Collaborator

Description

Related to pr #171

Why: Make the code cleaner, and not reuse code
How: Put the shell code in separate file and use this code from file when needed

screenshots

Don't need here

@ArkadiK94 ArkadiK94 requested a review from NoamGaash as a code owner November 6, 2023 19:19
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for astonishing-pothos-5f81bd ready!

Name Link
🔨 Latest commit 48dd447
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/654e6362f737700008410cf2
😎 Deploy Preview https://deploy-preview-181--astonishing-pothos-5f81bd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NoamGaash
Copy link
Member

@ArkadiK94
Copy link
Collaborator Author

Hmm, the repo of this github action has only 9 starts. It contains only few files and doesn't affect the production but still do you want to take the risk using it in this project? 🤔

@NoamGaash
Copy link
Member

it doesn't seem so riskey
anyway, we can also write a composite action instead
https://docs.github.com/en/actions/creating-actions/creating-a-composite-action

@ArkadiK94
Copy link
Collaborator Author

ArkadiK94 commented Nov 8, 2023

Yup, I will do it. I have one question regarding it. Do you want me create the action folder inside this project or add new repo in the Hasadna github page so people could use it in future projects? This action can be helpful almost in every Frontend project.

@NoamGaash
Copy link
Member

NoamGaash commented Nov 9, 2023

There are many github actions that are already available for this, feel free to choose one or create one yourself, it's up to you

@ArkadiK94
Copy link
Collaborator Author

@NoamGaash I created new github action https://github.com/ArkadiK94/action-git-clean-tree and used it here.

@ArkadiK94 ArkadiK94 requested a review from NoamGaash November 10, 2023 17:09
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👏

@ArkadiK94 ArkadiK94 merged commit 514eb90 into main Nov 10, 2023
11 checks passed
@ArkadiK94 ArkadiK94 deleted the test/ci branch November 10, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants