Create LICENSE.md #4
Open
+61
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid the overhead incurred of one (open, write, close) of the local file per record, open the local file once per batch and store it in the context for re-use across the batch. I haven't finished processing the results of the pre-patch run against the same data (because it's taking so long), but the run with this patch took only 20 seconds: ``` poetry run target-s3-jsonl --config .config --input braze-output.singer 20.03s user 1.18s system 42% cpu 49.574 total ``` And, anecdotally, I was able to get a full meltano run of tap-braze -> target-s3-jsonl run in ~11 minutes on my local machine.
soumyadsanyal-harrys
requested review from
jwisdom-harrys,
rishi-gajula-harrys,
ynaim94-harrys and
a team
jwisdom-harrys
previously approved these changes
Feb 15, 2023
1. Apache 2.0 --> MIT
soumyadsanyal-harrys
force-pushed
the
soumyadsanyal/DENG-2259/license
branch
from
920612e
to
3caea5a
Compare
|
Rebased on re-use-fd-per-batch, please merge in that order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MIT license.