-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalogue match instruments #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The endpoint
text/match
will now also return a list of instruments (each instrument containing a list of best instrument matches from the catalogue). Each instrument question also includes the best matched question from the catalogue. A list of best instrument matches from the catalogue is also included for all the instruments.By default, the catalogue instruments matches will not be included.
To include them, add the following query parameters (optional):
include_catalogue_matches
set totrue
to include the catalogue instrument matches.catalogue_sources
to only return matches from a specific source e.g.MHC
etc.Example:
http://localhost:8000/text/match?include_catalogue_matches=true&catalogue_sources=mhc&catalogue_sources=closer
The catalogue data required for matching will be downloaded from
Azure Blob Storage
, for this to work include the env variableAZURE_STORAGE_URL
(link to where the files are uploaded).Only the model
sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
is currently supported for catalogue matching.Type of change