Fix loading env GOOGLE_APPLICATION_CREDENTIALS #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type for
GOOGLE_APPLICATION_CREDENTIALS
was changed fromdict
tostr | None
insettings.py
. Previously a crash would occur if the provided value is not a valid JSON or is empty. Now, an attempt to load the env variable as a dictionary is done ingoogle_embeddings.py
within a try-except block, when this is successful, the Google models will be loaded, else they are not available.Fixes #12
Type of change
Testing
Tested the following to make sure the app does not crash:
GOOGLE_APPLICATION_CREDENTIALS
.GOOGLE_APPLICATION_CREDENTIALS
.GOOGLE_APPLICATION_CREDENTIALS
where the content does not contain the keys expected (the expected content is the content ofcredentials.json
).