Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sentence-transformers to 3.0.0 to fix Update huggingface … #74

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

animesh-77
Copy link
Contributor

…hub to newest version #67

Description

Version upgrade: sentence-transformers 2.2.2 → 3.0.0

Updated the version in pyproject.toml and requirements.txt

Fixes # (issue)

NA

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)?
  • Chore (non-breaking change, version update)

Testing

Tests create no new warnings or errors
Before changes

  • tox -e py310 --recreate 44 passed 48 warnings
  • tox -e py311 --recreate 44 passed 48 warnings

After changes

  • tox -e py310 --recreate 44 passed 48 warnings
  • tox -e py311 --recreate 44 passed 48 warnings

Since the Harmony Python package is used by the Harmony API (which is itself used by the R library and the web app), we need to avoid making any changes that break the Harmony API. Please also run the Harmony API unit tests and check that the API still runs with your changes to the Python package: https://github.com/harmonydata/harmonyapi

Test Configuration

  • Library version: tox==4.23.2
  • OS: Ubuntu 22.04.5 LTS
  • Toolchain: VSCode 1.96

Checklist

  • My code follows the style guidelines of this project. I have applied a Linter (recommended: Pycharm's code formatter) to make my whitespace consistent with the rest of the project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The Harmony API is not broken by my change to the Harmony Python library
  • If I introduced a new feature, I documented it (e.g. making a script example in the script examples repository so that people will know how to use it.

discordapp.com/users/Animesh77

@woodthom2 woodthom2 merged commit 47294a7 into harmonydata:main Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants