Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#62 Added crosswalk table + unit tests #65

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

vkrithika25
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

I ran a test with some dummy questions and a fake similarity matrix which I created to test base functionality. I ensured that questions were not flagged as having similarities with themselves and ensured that no similarity scores below the threshold are flagged. I also wrote a test which calls match_instruments and uses its outputs as inputs into the generate_crosswalk_table function.

Test Configuration

  • Library version: v1.0.0
  • OS: Windows
  • Toolchain: Python 3.11.9, PyCharm

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@woodthom2 woodthom2 merged commit 093518e into harmonydata:main Nov 17, 2024
1 check passed
@woodthom2
Copy link
Contributor

Thanks Krithika! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants