Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update huggingface hub to newest version #67

Open
woodthom2 opened this issue Nov 26, 2024 · 3 comments
Open

Update huggingface hub to newest version #67

woodthom2 opened this issue Nov 26, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@woodthom2
Copy link
Contributor

Description

At present HuggingFace Hub is locked at 0.25.0 in requirements.txt

I had to lock it at an old version because if we allow it to update then it breaks the install since the method cached_download has been deprecated and we get this error on all platforms.

ImportError: cannot import name 'cached_download' from 'huggingface_hub' (/tmp/harmony/venv/lib/python3.11/site-packages/huggingface_hub/__init__.py)

Environment

Provide details regarding the operating system, toolchain, and environment.

How to Reproduce

  1. Clone Harmony as at this commit: 3de5b8c
  2. There is nothing in requirements.txt locking huggingface-hub to any version
  3. Installation will default to huggingface-hub==0.26.2 or whatever is currently most recent version on Pypi
  4. Error ImportError: cannot import name 'cached_download' from 'huggingface_hub' (/tmp/harmony/venv/lib/python3.11/site-packages/huggingface_hub/__init__.py)

Expected Behavior

Update the code in Harmony so that it will work with a newer version of this dependency

@woodthom2 woodthom2 added bug Something isn't working good first issue Good for newcomers labels Nov 26, 2024
@animesh-77
Copy link
Contributor

I'd like to take up this issue @woodthom2

@woodthom2
Copy link
Contributor Author

Thanks Animesh feel free to do this and it was great to meet you yesterday!

@animesh-77
Copy link
Contributor

animesh-77 added a commit to animesh-77/harmony that referenced this issue Dec 16, 2024
animesh-77 added a commit to animesh-77/harmony that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants