Shared entities: use target instead of actionableBy #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rather than the actionableBy
| @@ -29,6 +31,17 @@ var tableSharedRolesSelect = function(M, entityName) { | |||
| return q.length ? q[0] : null; | |||
| }; | |||
|
|
|||
| var replaceActionableByMaybe = function(M, actionableBy) { | |||
| if(USE_TARGET_FOR_ENTITIES.length) { | |||
There was a problem hiding this comment.
I think this will throw an exception is the config isn't defined. You should default it to [] on line 14 above to avoid this
jennylouisew
requested changes
Oct 14, 2022
There was a problem hiding this comment.
Hey - sorry, this was the wrong repo to make these changes in. You want https://github.com/haplo-org/haplo-standard-plugins-dev instead. Changes to standard plugins are made there and eventually migrated to here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was implemented to resolve the issue surrounding delegation in the Ethics product.
In Ethics, we use "targetApproverPerson" rather than the entity name as the state's actionableBy. In this case, we want to instead check M.target for the shared entity to allow delegation.
To test, add
feature std:configuration-data property: {"std_workflow:entity_shared_roles:use_target_for_entities": ["targetApproverPerson"]}to ethics/hres_ethics/requirements.schema.
Upload to 9a55 (please let me know before you use the system).
Test application: https://dev9a55.infomanaged.co.uk/8v30y/ethics-application-eth2022-0165-