[integ-test-framework] Ensure xdist fixture cleanup even when test cr…

…ashes Prior to this commit, the fixture was cleaned up if tests succeeded or tests failed assertion. The fixture was not cleaned up if tests failed severely (e.g. index an item not existed in a list). This commit makes sure the cleanup is always executed Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste · Oct 30, 2024 · 6d6b08c · 6d6b08c
1 parent 4f48d09
commit 6d6b08c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/tests/integration-tests/framework/fixture_utils.py b/tests/integration-tests/framework/fixture_utils.py
@@ -221,8 +221,10 @@ def _xdist_session_fixture(request, *args, **kwargs):
                 fixture_func_kwargs=kwargs,
                 xdist_worker_id_and_pid=f"{xdist_worker_id}: {pid}",
             )
-            yield shared_fixture.acquire().fixture_return_value
-            shared_fixture.release()
+            try:
+                yield shared_fixture.acquire().fixture_return_value
+            finally:
+                shared_fixture.release()
 
         return _xdist_session_fixture