Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Removing more Deprecated methods #3168

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Jan 6, 2025

What

.asInternalName() has been deprecated for 2-3 months now I think.
And removed some other basically unused methods, rewrote some small things to not use deprecated stuff anymore.

Changelog Technical Details

  • Removed deprecated methods. - j10a1n15

Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
@github-actions github-actions bot added Backend A backend pull request that will be merged soon Detekt Has detekt problem labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

One or more Detekt Failures were detected:

Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 6, 2025
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jani270 jani270 added this to the Version 2.0.0 milestone Jan 6, 2025
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 7, 2025
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 merged commit 8f79ba7 into hannibal002:beta Jan 7, 2025
6 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Jan 7, 2025
@j10a1n15 j10a1n15 deleted the deprecated branch January 8, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants