Feature: SkyblockXP Bar #2886
Merged
Feature: SkyblockXP Bar #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
github-actions
bot
added
the
Wrong Title/Changelog
|
I have detected some issues with your pull request: Title issues: Please fix these issues. For the correct format, refer to the pull request template. |
github-actions
bot
removed
the
Wrong Title/Changelog
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
jani270
added
the
Soon
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java
Signed-off-by: J10a1n15 <[email protected]>
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
One or more Detekt Failures were detected:
|
this is not a joke I actually missed the build error
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
One or more Detekt Failures were detected:
|
Signed-off-by: J10a1n15 <[email protected]>
hannibal002
requested changes
Jan 13, 2025
src/main/java/at/hannibal2/skyhanni/config/features/inventory/InventoryConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/SkyBlockXPBar.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: J10a1n15 <[email protected]>
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This Pull Request adds an option to have your skyblock xp + progress in your vanilla xp bar. It also adds a SkyblockXP API which gets the data from the tablist and the skyblock menu as a fallback.
Images
Changelog New Features
Changelog Technical Details