Backend: Better Enchant Detection and Error Logging #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMWolfs
added
the
Soon
CalMWolfs
approved these changes
Oct 25, 2024
hannibal002
requested changes
Oct 26, 2024
src/main/java/at/hannibal2/skyhanni/features/misc/items/enchants/EnchantParser.kt
Show resolved
Hide resolved
github-actions
bot
added
the
Wrong Title/Changelog
|
I have detected some issues with your pull request: Title issues: Please fix these issues. For the correct format, refer to the pull request template. |
VixidDev
changed the title
github-actions
bot
added
Backend
hannibal002
approved these changes
Oct 27, 2024
|
Closing and reopening to try fixing auto merge not working |
auto-merge was automatically disabled
October 27, 2024 21:30
Pull request was closed
github-actions
bot
removed
Soon
github-actions
bot
added
the
Backend
github-actions
bot
removed
the
Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a regex pattern to check that a line contains only enchants (and anything else expected in a legitimate enchant line) so miscellaneous strings from elsewhere in the mod or from other mods are not messed with incorrectly. Also fixes and improves the error logging in enchant parser for some still unexplained errors.
test
Changelog Technical Details