Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Block Strength #2778

Open
wants to merge 28 commits into
base: beta
Choose a base branch
from

Conversation

Thunderblade73
Copy link
Contributor

Dependencies

What

Shows how many ticks you need to break any block with your mining speed.

It opens the skyblock menu to collect up to date stats.

Images

image

Changelog New Features

  • Added /shblockstrength. - Thunderblade73
    • Shows how many ticks you need to break any block with your mining speed.

Changelog Technical Details

  • Added Renderable.renderAndScale. - Thunderblade73
  • Added the title of the Inventory to InventoryCloseEvent. - Thunderblade73

@lunaynx
Copy link
Contributor

lunaynx commented Oct 20, 2024

One small issue, this won't be fully accurate with HOTM perks and tools/pets that give extra Mining Speed only for specific types of blocks. This could probably be read from HotmAPI and then hardcode known cases for tools/pets (or try to read it out from their lore).

@hannibal002 hannibal002 added this to the Version 0.29 milestone Oct 20, 2024
@Thunderblade73
Copy link
Contributor Author

One small issue, this won't be fully accurate with HOTM perks and tools/pets that give extra Mining Speed only for specific types of blocks. This could probably be read from HotmAPI and then hardcode known cases for tools/pets (or try to read it out from their lore).

I added a way to account for them now. I only implemented HOTM perks since I don't know other sources of specific speed.

@Thunderblade73
Copy link
Contributor Author

One small issue, this won't be fully accurate with HOTM perks and tools/pets that give extra Mining Speed only for specific types of blocks. This could probably be read from HotmAPI and then hardcode known cases for tools/pets (or try to read it out from their lore).

I added a way to account for them now. I only implemented HOTM perks since I don't know other sources of specific speed.

Empa gave me a full list. It does now account for lapidary, Gemstone drills as well. And I also added a todo with the remaining sources.

Copy link

github-actions bot commented Nov 1, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 1, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/mining/OreBlock.kt
#	src/main/java/at/hannibal2/skyhanni/utils/InventoryUtils.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Conflicts have been resolved! 🎉

Copy link

github-actions bot commented Nov 1, 2024

One or more Detekt Failures were detected:

Copy link

github-actions bot commented Nov 1, 2024

One or more Detekt Failures were detected:

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/mining/OreBlock.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

Conflicts have been resolved! 🎉

Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 17, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/utils/InventoryUtils.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 31, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 31, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/data/model/SkyblockStat.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 31, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/data/OtherInventoryData.kt
#	src/main/java/at/hannibal2/skyhanni/data/ScreenData.kt
#	src/main/java/at/hannibal2/skyhanni/events/InventoryCloseEvent.kt
Copy link

github-actions bot commented Jan 8, 2025

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants