Backend: Hypixel Mod API #2768
Merged
Backend: Hypixel Mod API #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Backend
|
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
github-actions
bot
removed
the
Wrong Title/Changelog
…to serverName *just in case*
Signed-off-by: Empa <[email protected]>
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/features/dev/DevConfig.java # src/main/java/at/hannibal2/skyhanni/data/HypixelData.kt # src/main/java/at/hannibal2/skyhanni/events/HypixelJoinEvent.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
Signed-off-by: Empa <[email protected]>
jani270
added
the
Soon
One or more Detekt Failures were detected:
|
Signed-off-by: Empa <[email protected]>
github-actions
bot
removed
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements the Hypixel Mod API and creates HypixelAPIServerChangeEvent with it.
The goal of using the mod api is having more precise information, like hypixel, skyblock, and island detection. This pr just adds the functionality but doesnt use it: it only compares it to the one in the current system, and sends an error message in chat if the comparison fails. This is gonna be like this for a couple betas, and if things go well the old system will start getting changed to use the mod api.
Changelog Technical Details