Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Mining Notifications v2 #2073

Draft
wants to merge 6 commits into
base: beta
Choose a base branch
from

Conversation

martimavocado
Copy link
Contributor

@martimavocado martimavocado commented Jun 12, 2024

Dependencies

What

Adds a few more mining notifications:

  • Pickaxe Ability Ready
  • Pickaxe Ability Used
  • Pickaxe Ability Expired
  • Commission completed

Removed the Mineshaft Spawned notification since hypixel added it.

replacing #1564

Changelog Improvements

  • Added new Mining Notifications. - martimavocado
    • This includes Pickaxe Ability Ready, Used and Expired, and Commission completed.

Changelog Removed Features

  • Removed Mineshaft Spawned from Mining Notifications. - martimavocado

@hannibal002 hannibal002 added this to the Version 0.27 milestone Jun 12, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 15, 2024
…s-v2

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/mining/MiningNotifications.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 15, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jul 30, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

…ions-v2

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/ConfigUpdaterMigrator.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 26, 2024
@martimavocado martimavocado marked this pull request as draft September 26, 2024 02:34
Copy link

github-actions bot commented Oct 5, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflicts There are open merge conflicts with the beta branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants