Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hanami::Action::Config#root: don't check realpath existence #429

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Hanami::Action::Config#root: don't check realpath existence #429

merged 1 commit into from
Sep 27, 2023

Conversation

jodosha
Copy link
Member

@jodosha jodosha commented Sep 27, 2023

Hanami::Action::Config#root: don't check Pathname#realpath existence to simplify the boot process of Hanami.

Ref hanami/hanami#1333 (comment)

@jodosha jodosha added this to the v2.1.0 milestone Sep 27, 2023
@jodosha jodosha self-assigned this Sep 27, 2023
timriley
timriley approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@timriley timriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jodosha jodosha merged commit fb74e0e into main Sep 27, 2023
9 checks passed
@jodosha jodosha deleted the fix/config-root-do-not-check-realpath branch September 27, 2023 12:59
@jodosha jodosha mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timriley timriley timriley approved these changes

Assignees

@jodosha jodosha

Labels
None yet
Projects
Hanami 2.1
Status: Done
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jodosha @timriley