Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing in custom options for OCF decoder. #460

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

mfycheng
Copy link
Contributor

Currently, the OCF Decoder will fail when parsing OCF files that contain a field that exceeds the default limit of 1MiB. There is currently no way to configure this limit for the OCF Decoder.

This change provides a way to construct an OCF Decoder using a custom avro.API, which enables configuration of the decoder.

Currently, the OCF Decoder will fail when parsing OCF files that contain
a field that exceeds the default limit of 1MiB. There is currently no
way to configure this limit for the OCF Decoder.

This change provides a way to construct an OCF Decoder using a custom
avro.API, which enables configuration of the decoder.
ocf/ocf.go Outdated Show resolved Hide resolved
@mfycheng mfycheng requested a review from nrwiersma September 27, 2024 13:50
Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏻

@nrwiersma nrwiersma merged commit b4fe207 into hamba:main Sep 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants