fix: Long timestamp default decoding #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking about #368, the fix seems to me overly restrictive and beyond the problem’s scope: The accidental case of encoding a time.Duration value (which is practically in nano second) as timestamp in milliseconds. IMHO, that’s a misuse of GO types and not a bug in the library’s implementation of AVRO spec. |
|
You are likely right that it should be more specific to only restricting the |
redaLaanait
force-pushed
the
fix_timestamp_default_decoding
branch
from
a123069 to
cb3d6f5
Compare
|
I agree with the approach. This looks like a good fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#368 related
The previous fix made a restriction to prevent accepting
int64as a Go type for the Long-timestamp codec. However, this restriction affected thedefaultDecoderwhen dealing with the JSON-decoded default value represented asint64.A solution could be:
1 - Improve the default JSON decoding to ensure that the default value is correctly represented as
time.Time.2- Relax the restriction made in the previous fix and limit it to the case of
time.Duration.The PR draft presents these solutions, and a test has been added to cover this case.