Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify the pointer used #323

Merged
merged 1 commit into from
Nov 5, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codec_record.go
Original file line number Diff line number Diff line change
@@ -176,7 +176,6 @@ func encoderOfStruct(cfg *frozenConfig, schema Schema, typ reflect2.Type) ValEnc
if defaultType.LikePtr() {
defaultEncoder = &onePtrEncoder{defaultEncoder}
}

fields = append(fields, &structFieldEncoder{
defaultPtr: reflect2.PtrOf(def),
encoder: defaultEncoder,
@@ -332,6 +331,8 @@ type recordMapEncoder struct {

func (e *recordMapEncoder) Encode(ptr unsafe.Pointer, w *Writer) {
for _, field := range e.fields {
// The first property of mapEncoderField is the name, so a pointer
// to field is a pointer to the name.
valPtr := e.mapType.UnsafeGetIndex(ptr, reflect2.PtrOf(field))
if valPtr == nil {
// Missing required field