Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tag style "original" for additional tags #313

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

founderio
Copy link
Contributor

Some edge cases require using the tag style from avro as-is for other formats.
The tag style original explicitly does not do any processing on the tag before code generation.

This is mostly already supported in the code generation, but the CLI options would reject
any configuration value which would trigger this behaviour.

@nrwiersma nrwiersma self-requested a review October 2, 2023 13:27
@founderio founderio force-pushed the feature/tag_style_original branch from 0b96d04 to be1e1a1 Compare October 2, 2023 13:27
Some edge cases require using the tag style from avro as-is
for other formats.
The tag style `original` explicitly does not do any processing
on the tag before code generation.

This is mostly already supported in the code generation,
but the CLI options would reject
any configuration value which would trigger this behaviour.
@founderio founderio force-pushed the feature/tag_style_original branch from be1e1a1 to e948cf9 Compare October 3, 2023 12:55
Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@nrwiersma nrwiersma merged commit 3ac44d5 into hamba:main Oct 3, 2023
2 checks passed
@founderio founderio deleted the feature/tag_style_original branch October 3, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants