rebrand custom phases as ROIs

halworsen · Mar 2, 2024 · 12b68c5 · 12b68c5
1 parent fbaf9b4
commit 12b68c5
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 5 deletions.
diff --git a/fflogsapi/data/__init__.py b/fflogsapi/data/__init__.py
@@ -10,7 +10,7 @@
                           FFLogsReportComboRanking, FFLogsReportRanking, FFLogsReportTag,
                           FFLogsZoneEncounterRanking, FFLogsZoneRanking, FFMap,)
 
-from .phases import PhaseType, PhaseInformation, OmegaPhaseData, AlexanderPhaseData, ALL_PHASE_DATA
+from .rois import PhaseType, PhaseInformation, OmegaPhaseData, AlexanderPhaseData, ALL_PHASE_DATA
 
 __all__ = [
     # dataclasses.py
@@ -40,7 +40,7 @@
     'FFLogsPartition',
     'FFLogsPhase',
 
-    # .phases
+    # .rois
     'PhaseType',
     'PhaseInformation',
     'OmegaPhaseData',

diff --git a/fflogsapi/data/phases/__init__.py → fflogsapi/data/rois/__init__.py b/fflogsapi/data/phases/__init__.py → fflogsapi/data/rois/__init__.py
diff --git a/fflogsapi/data/phases/alexander.py → fflogsapi/data/rois/alexander.py b/fflogsapi/data/phases/alexander.py → fflogsapi/data/rois/alexander.py
diff --git a/fflogsapi/data/phases/omega.py → fflogsapi/data/rois/omega.py b/fflogsapi/data/phases/omega.py → fflogsapi/data/rois/omega.py
diff --git a/fflogsapi/data/phases/phases.py → fflogsapi/data/rois/phases.py b/fflogsapi/data/phases/phases.py → fflogsapi/data/rois/phases.py
diff --git a/fflogsapi/reports/fight.py b/fflogsapi/reports/fight.py
@@ -183,7 +183,7 @@ def duration(self) -> float:
         return self.end_time() - self.start_time()
 
     @fetch_data('encounterID')
-    def phases(self) -> Optional[list['PhaseInformation']]:
+    def phase_rois(self) -> Optional[list['PhaseInformation']]:
         '''
         WARNING: VERY SLOW!
 

diff --git a/tests/reports/test_phases.py → tests/reports/test_rois.py b/tests/reports/test_phases.py → tests/reports/test_rois.py
@@ -6,9 +6,9 @@
 from ..config import CACHE_EXPIRY, CLIENT_ID, CLIENT_SECRET
 
 
-class FightTest(unittest.TestCase):
+class ROITest(unittest.TestCase):
     '''
-    Test cases for fight phases.
+    Test cases for the ROI toolkit
 
     This test case makes assumptions on the availability of specific reports.
     If the tests break, it may be because visibility settings