Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove forwardRef from components #58

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

halvaradop
Copy link
Owner

@halvaradop halvaradop commented Nov 30, 2024

Description

This pull request removes the unnecessary forwardRef function from components as it isn't required in the latest version of React (19). Additionally, it updates the SlotProps type to infer the element and return the props based on the tag.

Checklist

  • Added documentation.
  • The changes do not generate any warnings.
  • I have performed a self-review of my own code
  • All tests have been added and pass successfully

Notes

@halvaradop halvaradop merged commit 446cae0 into master Nov 30, 2024
3 checks passed
@halvaradop halvaradop deleted the chore/remove-forwardref branch November 30, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant