Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine user interface #10

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 16, 2024

Some user interface improvements

  1. Use codemirror to edit text diagram code

    图片
  2. Display mermaid error

    图片
  3. Add fullscreen feature

    图片
  4. Add documentation link

    图片

/kind improvements

优化 UI 界面,提升易用性

Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 16, 2024
Copy link

f2c-ci-robot bot commented Jan 16, 2024

@ruibaby: The label(s) kind/improvements cannot be applied, because the repository doesn't have them.

In response to this:

Some user interface improvements

  1. Use codemirror to edit text diagram code

    图片
  2. Display mermaid error

    图片
  3. Add fullscreen feature

    图片
  4. Add documentation link

    图片

/kind improvements

优化 UI 界面,提升易用性

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang January 16, 2024 07:32
@ruibaby
Copy link
Member Author

ruibaby commented Jan 16, 2024

After this, we can try adding syntax support for Mermaid and PlantUML in Codemirror. There is already a library available that supports Mermaid syntax: https://github.com/inspirnathan/codemirror-lang-mermaid

Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 91cb732 into halo-sigs:main Jan 16, 2024
4 checks passed
@ruibaby ruibaby deleted the refactor/refine-ui branch January 16, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants