Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the ui of moments interface and remove the search feature #79

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Feb 5, 2024

What type of PR is this?

/kind improvement

What this PR does / why we need it:

由于在 #69 中,更改了 moment 的索引,并且未对 moment 全文做索引,因此实际上目前 moment 的搜索功能是无效的。

此 PR 基于此原因,移除了页面中的全文搜索功能,并对 moment 整体 UI 做了调整。使其更加适合当前基于标签的搜索功能。

Does this PR introduce a user-facing change?

重构瞬间列表界面 UI

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen February 5, 2024 07:14
Copy link

f2c-ci-robot bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnniang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing
Copy link
Member

guqing commented Feb 5, 2024

建议直接在此 PR 重构搜索条件并作为改进或 feature

@LIlGG LIlGG changed the title pref: remove frontend search box WIP: pref: remove frontend search box Feb 5, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2024
@guqing guqing changed the title WIP: pref: remove frontend search box WIP: pref: refine ui for moment list Feb 19, 2024
@LIlGG LIlGG changed the title WIP: pref: refine ui for moment list refactor: refactor the ui of moments interface and remove the search feature Feb 19, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@ruibaby ruibaby self-requested a review February 19, 2024 08:49
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@ruibaby ruibaby merged commit 1c6d3af into halo-sigs:main Feb 21, 2024
1 check was pending
@LIlGG LIlGG deleted the pref/remove-search branch February 21, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants