Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support moment user center #68

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Dec 25, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

支持在个人中心发布瞬间

How to test it?

在个人中心发布瞬间,并测试相关权限是否正常。

Which issue(s) this PR fixes:

Fixes #47
Fixes #53

Does this PR introduce a user-facing change?

适配在个人中心发布瞬间

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 25, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen December 25, 2023 10:47
Copy link

f2c-ci-robot bot commented Dec 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ruibaby for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chengzhongxue
Copy link
Contributor

这个功能是不是遥遥无期了

@LIlGG
Copy link
Member Author

LIlGG commented Apr 11, 2024

这个功能是不是遥遥无期了

可能需要 Halo 的支持。由于瞬间使用了 AttachmentSelectorModal 来选择附件上传,但此组件只在 Console 中注册过,并没有在 UC 中注册,因此现在个人中心无法使用添加多媒体附件的功能。

如果不考虑多媒体附件的功能,此 PR 大致功能已经结束。

See halo-dev/halo#5278

@chengzhongxue
Copy link
Contributor

这个功能是不是遥遥无期了

可能需要 Halo 的支持。由于瞬间使用了 AttachmentSelectorModal 来选择附件上传,但此组件只在 Console 中注册过,并没有在 UC 中注册,因此现在个人中心无法使用添加多媒体附件的功能。

如果不考虑多媒体附件的功能,此 PR 大致功能已经结束。

See halo-dev/halo#5278

好吧

@LIlGG LIlGG changed the title WIP: feat: support moment user center feat: support moment user center Apr 11, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@ruibaby
Copy link
Member

ruibaby commented May 6, 2024

建议添加 发布无需审核的权限,目前发现勾选了这两个权限之后还是需要审核,可能对于使用者来说不是很方便。

image image

@LIlGG
Copy link
Member Author

LIlGG commented May 6, 2024

建议添加 发布无需审核的权限,目前发现勾选了这两个权限之后还是需要审核,可能对于使用者来说不是很方便。

已添加

@ruibaby ruibaby requested review from JohnNiang and guqing May 6, 2024 15:13
@JohnNiang
Copy link

Hi @LIlGG ,请先解决一下冲突。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

实际测试符合预期。

Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JohnNiang JohnNiang added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 7, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit d842fb4 into halo-sigs:main May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

可以提供前台发瞬间? 会适配多用户?
4 participants