Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect hash tag link #140

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: incorrect hash tag link #140

merged 1 commit into from
Dec 10, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 10, 2024

What this PR does?

修复标签链接不正确的问题

Fixes #139

修复标签相对链接不正确的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen December 10, 2024 07:23
@guqing guqing force-pushed the fix/139 branch 2 times, most recently from 259b69c to 69a4363 Compare December 10, 2024 07:25
@guqing guqing requested review from ruibaby and LIlGG and removed request for JohnNiang and wan92hen December 10, 2024 07:25
@ruibaby
Copy link
Member

ruibaby commented Dec 10, 2024

https://github.com/halo-sigs/plugin-moments/blob/main/src/main/java/run/halo/moments/vo/MomentTagVo.java

在主题列出 Tag 列表的时候也需要手动构造地址,要不要也塞一个呢

@guqing
Copy link
Member Author

guqing commented Dec 10, 2024

https://github.com/halo-sigs/plugin-moments/blob/main/src/main/java/run/halo/moments/vo/MomentTagVo.java

在主题列出 Tag 列表的时候也需要手动构造地址,要不要也塞一个呢

可以

@guqing
Copy link
Member Author

guqing commented Dec 10, 2024

在主题列出 Tag 列表的时候也需要手动构造地址,要不要也塞一个呢

Done

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
Copy link

f2c-ci-robot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 22d08c4 into main Dec 10, 2024
2 checks passed
@guqing guqing deleted the fix/139 branch December 10, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

瞬间的标签地址不正确
2 participants