Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use globally provided axios instance #114

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 26, 2024

使用 Halo 全局提供的 axios 实例请求接口,不再需要在插件中处理请求异常逻辑,并且可以减小包体积。

/kind improvement

Fixes #87

使用 Halo 全局提供的 axios 实例请求接口

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen June 26, 2024 06:24
@ruibaby
Copy link
Member Author

ruibaby commented Jun 26, 2024

/hold 等待 Halo 2.17 发布

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@ruibaby ruibaby force-pushed the refactor/api-client branch from 43f3590 to 1ece65e Compare July 2, 2024 06:39
@guqing
Copy link
Member

guqing commented Jul 2, 2024

/unhold

Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 8aefa28 into halo-sigs:main Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

会话超时后,插件会报undefined错,没有弹窗登录页面
3 participants