Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layout issues on low-resolution screens #112

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 13, 2024

修复在低分屏下的布局问题。

/kind bug

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jun 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen June 13, 2024 03:05
@ruibaby ruibaby requested a review from LIlGG June 13, 2024 03:19
@LIlGG
Copy link
Member

LIlGG commented Jun 13, 2024

之前在低分屏下的表现是如何的?当前 PR 改完之后感觉整体长度变长了。

@ruibaby
Copy link
Member Author

ruibaby commented Jun 13, 2024

之前在低分屏下的表现是如何的?当前 PR 改完之后感觉整体长度变长了。

会因为之前 Container 的 padding 预设,导致在低分屏下两边空白过多,而中间的元素会挤在一起。晚些时候我会复现一下。

Signed-off-by: Ryan Wang <[email protected]>
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link

f2c-ci-robot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LIlGG
Once this PR has been reviewed and has the lgtm label, please ask for approval from ruibaby. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby merged commit 1eb0130 into halo-sigs:main Jun 14, 2024
1 of 2 checks passed
@ruibaby ruibaby deleted the fix/layout branch June 14, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants