Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt NON-ADMIN users #7

Merged
merged 9 commits into from
Aug 5, 2024
Merged

feat: adapt NON-ADMIN users #7

merged 9 commits into from
Aug 5, 2024

Conversation

Roozenlz
Copy link
Collaborator

@Roozenlz Roozenlz commented Aug 1, 2024

适配非 ADMIN 用户 #3 (comment)
处理下载链接编码问题 #5 (comment)
/kind improvement

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby August 1, 2024 16:22
@Roozenlz Roozenlz requested a review from JohnNiang August 2, 2024 10:13
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2024
Copy link

f2c-ci-robot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ec2ad22 into main Aug 5, 2024
2 checks passed
@JohnNiang JohnNiang deleted the fix branch August 5, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants