Refactor AList attachment handler and AList verification #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohnNiang <[email protected]>
f2c-ci-robot
bot
added
kind/improvement
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: JohnNiang <[email protected]>
JohnNiang
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
I'm going to merge this PR manually if no further feedback. |
|
/ping @halo-sigs/halo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wholly refactors AList attachment handler and AList verification.
After uploading an attachment, we will put the annotation
alist.storage.halo.run/file-pathinto attachment annotations. Then we can use it while getting permalink and deleting it instead of usespec.displayName.BYW, the caches of tokens and WebClients are removed because I think they are unnecessary in this situation and they may cause some problems unexpected. If we encountered the performance issue in the future, the feature would be considered again.
Meanwhile, uploading file will be renamed automatically if it's name already exists.
/kind improvement
Fixes #13
Fixes #16