Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ui design #42

Merged
merged 14 commits into from
Aug 8, 2024
Merged

refactor: ui design #42

merged 14 commits into from
Aug 8, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 6, 2024

优化搜索组件 UI。

plugin-search-widget-1.5.2-dev.jar.zip

image
重构搜索组件的 UI

Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 6, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang August 6, 2024 07:34
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2024
ruibaby and others added 8 commits August 7, 2024 12:58
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
@JohnNiang
Copy link
Member

当前修改似乎没有适配夜间模式,请看截图:

image

@ruibaby
Copy link
Member Author

ruibaby commented Aug 8, 2024

当前修改似乎没有适配夜间模式,请看截图:

image

更新了,用 plugin-search-widget-1.5.2-dev.jar.zip

@JohnNiang
Copy link
Member

Cool.

image

ruibaby added 2 commits August 8, 2024 11:07
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
@ruibaby
Copy link
Member Author

ruibaby commented Aug 8, 2024

/retitle refactor: ui design

@f2c-ci-robot f2c-ci-robot bot changed the title WIP: refactor: ui design refactor: ui design Aug 8, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 8, 2024
Signed-off-by: Ryan Wang <[email protected]>
Copy link

f2c-ci-robot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 39cc9eb into halo-dev:main Aug 8, 2024
2 checks passed
@ruibaby ruibaby deleted the refactor/ui branch August 8, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants