skip deleting object from S3

halo-dev · Nov 27, 2023 · e8f2e9f · e8f2e9f
1 parent 660a874
commit e8f2e9f
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/main/java/run/halo/s3os/S3OsAttachmentHandler.java b/src/main/java/run/halo/s3os/S3OsAttachmentHandler.java
@@ -91,8 +91,14 @@ public Mono<Attachment> delete(DeleteContext deleteContext) {
         return Mono.just(deleteContext).filter(context -> this.shouldHandle(context.policy()))
             .flatMap(context -> {
                 var objectKey = getObjectKey(context.attachment());
-                if (objectKey == null || MetadataUtil.nullSafeAnnotations(context.attachment())
+                if (objectKey == null) {
+                    log.warn(
+                        "Cannot obtain object key from attachment {}, skip deleting object from S3.",
+                        context.attachment().getMetadata().getName());
+                    return Mono.just(context);
+                } else if (MetadataUtil.nullSafeAnnotations(context.attachment())
                     .containsKey(SKIP_REMOTE_DELETION_ANNO)) {
+                    log.info("Skip deleting object {} from S3.", objectKey);
                     return Mono.just(context);
                 }
                 var properties = getProperties(deleteContext.configMap());