Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restructure RSS generation to support extension by other plugins #39

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Nov 28, 2024

What this PR does?

重写 RSS 生成并支持被其他插件扩展

重写 RSS 生成并支持被其他插件扩展

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen November 28, 2024 10:08
@guqing guqing force-pushed the feature/extensible branch from d573697 to b9f45f3 Compare November 29, 2024 03:42
@guqing
Copy link
Member Author

guqing commented Nov 29, 2024

/hold wait for halo-dev/halo#7094 to be merged

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2024
@guqing guqing force-pushed the feature/extensible branch from b9f45f3 to 4b42918 Compare December 3, 2024 07:42
@ruibaby
Copy link
Member

ruibaby commented Dec 3, 2024

站点地图是不是也可以这样做,halo-dev/plugin-sitemap#31

@guqing
Copy link
Member Author

guqing commented Dec 3, 2024

站点地图是不是也可以这样做,halo-dev/plugin-sitemap#31

是的

@guqing guqing force-pushed the feature/extensible branch from 4b42918 to 8646bac Compare December 5, 2024 05:01
@guqing guqing force-pushed the feature/extensible branch 3 times, most recently from 591518a to 8fd11d4 Compare December 5, 2024 07:31
@guqing guqing force-pushed the feature/extensible branch from 8fd11d4 to 4fd2e3a Compare December 5, 2024 07:42
@guqing guqing changed the title [WIP] feat: restructure RSS generation to support extension by other plugins feat: restructure RSS generation to support extension by other plugins Dec 5, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
@guqing
Copy link
Member Author

guqing commented Dec 5, 2024

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit cff7c7e into main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants