Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update project infra #63

Merged
merged 2 commits into from
Sep 25, 2023
Merged

chore: update project infra #63

merged 2 commits into from
Sep 25, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 22, 2023

  1. 升级 Gradle 插件。
  2. 升级 pnpm 至 8.x。
  3. 更新 TypeScript 配置，解决 TypeScript 错误。

/kind cleanup

None

@f2c-ci-robot f2c-ci-robot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 22, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang September 22, 2023 09:00
guqing
guqing reviewed Sep 22, 2023
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@ruibaby @guqing
Update build.gradle
8066687 
Co-authored-by: guqing <[email protected]>
guqing
guqing approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
JohnNiang
JohnNiang approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby merged commit 5359f32 into halo-dev:main Sep 25, 2023
3 checks passed
@ruibaby ruibaby deleted the chore/infra branch September 25, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing approved these changes

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruibaby @JohnNiang @guqing