Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tags filter feature #53

Merged
merged 2 commits into from
Jan 18, 2024
Merged

feat: add tags filter feature #53

merged 2 commits into from
Jan 18, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 17, 2024

应用市场筛选项支持通过标签筛选。

图片 图片

plugin-app-store-1.0.0-SNAPSHOT.jar.zip

/kind feature

支持通过标签筛选应用

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang January 17, 2024 10:29
Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 18, 2024
@ruibaby
Copy link
Member Author

ruibaby commented Jan 18, 2024

/retitle feat: add tags filter feature

@f2c-ci-robot f2c-ci-robot bot changed the title WIP: feat: add tags filter feature feat: add tags filter feature Jan 18, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/approve

Copy link

f2c-ci-robot bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 4a8cefb into halo-dev:main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants