Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add packageManager for corepack #7081

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 26, 2024

What type of PR is this?

/area ui
/kind improvement

What this PR does / why we need it:

为 UI 项目添加 packageManager 字段,以支持 corepack

Which issue(s) this PR fixes:

Fixes #6635

Special notes for your reviewer:

Does this PR introduce a user-facing change?

为 UI 项目添加 packageManager 字段,以支持 [corepack](https://nodejs.org/api/corepack.html)。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. labels Nov 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG November 26, 2024 03:45
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.22%. Comparing base (eff73dc) to head (1bfa3a3).
Report is 66 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7081      +/-   ##
============================================
+ Coverage     56.99%   57.22%   +0.23%     
- Complexity     3999     4019      +20     
============================================
  Files           714      713       -1     
  Lines         24110    24212     +102     
  Branches       1585     1593       +8     
============================================
+ Hits          13742    13856     +114     
+ Misses         9756     9741      -15     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
Copy link

f2c-ci-robot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 033a77e into halo-dev:main Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望在ui的package.json中加入packageManager字段
2 participants