Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve role template i18n #7075

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 25, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

完善角色模板的 i18n。

image

Does this PR introduce a user-facing change?

完善角色模板的 i18n。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Nov 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Nov 25, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen November 25, 2024 01:33
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.24%. Comparing base (eff73dc) to head (94357ef).
Report is 61 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7075      +/-   ##
============================================
+ Coverage     56.99%   57.24%   +0.25%     
- Complexity     3999     4009      +10     
============================================
  Files           714      712       -2     
  Lines         24110    24154      +44     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13828      +86     
+ Misses         9756     9711      -45     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link

f2c-ci-robot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@JohnNiang JohnNiang merged commit ecec5ee into halo-dev:main Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants