-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support binding OAuth2 user automatically #6702
Support binding OAuth2 user automatically #6702
Conversation
application/src/main/java/run/halo/app/core/user/service/impl/UserConnectionServiceImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/core/user/service/impl/UserConnectionServiceImpl.java
Show resolved
Hide resolved
49c4fce
to
a286769
Compare
Signed-off-by: JohnNiang <[email protected]>
aaa9fc4
to
5b44e30
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已测试登录和注册之后都可以正常绑定。
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR refactors OAuth2 login for adapting Halo 2.20. See halo-dev/halo#6702 for more. #### How to build? 1. Checkout to halo-dev/halo#6702 2. Execute command `./gradlew publishToMavenLocal -Pversion=2.20.0+local.5` in Halo project 3. Execute command `./gradlew build` in current project. ```release-note None ```
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR add support for binding OAuth2 user automatically. So we can remove the user-binding page.
Please note that those changes may break the OAuth2 and SocialLogin plugins.
Special notes for your reviewer:
Build OAuth2 plugin from halo-sigs/plugin-oauth2#64 or use plugin-oauth2-1.0.4-SNAPSHOT.zip I built.
Does this PR introduce a user-facing change?