Keep length of PAT stable #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Niang <[email protected]>
f2c-ci-robot
bot
added
kind/improvement
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5374 +/- ##
============================================
- Coverage 56.91% 56.88% -0.03%
+ Complexity 3319 3315 -4
============================================
Files 587 586 -1
Lines 18968 18958 -10
Branches 1401 1400 -1
============================================
- Hits 10795 10785 -10
Misses 7594 7594
Partials 579 579 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.13.x
What this PR does / why we need it:
In fact, PAT is a JWT, which is very long. However, we put the claim
rolesinto PAT, which will cause the length of PAT to increase as therolesinformation increases.So, the current PR removes the claim
rolesfrom PAT, which ensures that the length of PAT becomes stable and we can update roles information for PAT at runtime.Which issue(s) this PR fixes:
Fixes #5366
Does this PR introduce a user-facing change?