Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of showing 500 error while containing special chars in excerpt #5263

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.12.0

What this PR does / why we need it:

This PR refactors building html meta by using modelFactory#createStandaloneElementTag.

See #4755 for more.

Which issue(s) this PR fixes:

Fixes #4755

Special notes for your reviewer:

Validate via #4755 (comment).

Does this PR introduce a user-facing change?

修复摘要中包含特殊字符导致无法解析页面的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 28, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.0 milestone Jan 28, 2024
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Jan 28, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试

<meta name="description" content="[(${a.b.v})] ${ag.bb.cc} [[${b.user}]] [(${name111.222})]"/>

<meta name="description" content="USER_IP=`who -u am i 2&gt;/dev/null| awk &#39;{print $NF}&#39;|sed -e &#39;s/[()]//g&#39;`"/>

均正常访问

@JohnNiang
Copy link
Member Author

/ping @halo-dev/sig-halo

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link

f2c-ci-robot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 47a1aa7 into halo-dev:main Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章发布后无法打开,500错误
3 participants