-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify halo plugin manager #5251
Simplify halo plugin manager #5251
Conversation
Signed-off-by: John Niang <[email protected]>
Signed-off-by: John Niang <[email protected]>
Signed-off-by: John Niang <[email protected]>
application/src/main/java/run/halo/app/plugin/PluginApplicationContext.java
Show resolved
Hide resolved
Signed-off-by: John Niang <[email protected]>
Signed-off-by: John Niang <[email protected]>
Signed-off-by: John Niang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
未见异常
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…scheme (#5271) #### What type of PR is this? /kind bug /area core /area plugin /milestone 2.12.0 #### What this PR does / why we need it: This PR adjusts the order of starting reconcilers in plugin, or it will be stuck in starting synchronizer and no reconcilers will be executed. The problem may be introduced by <#5251>. #### Does this PR introduce a user-facing change? ```release-note None ```
What type of PR is this?
/kind improvement
/area core
/area plugin
/milestone 2.12.x
What this PR does / why we need it:
This PR mainly simplifies halo plugin manager. Before this,
This PR does:
Meanwhile, this PR will supersede PR #5236.
Which issue(s) this PR fixes:
Fixes #5226
Special notes for your reviewer:
Test installing, enabing, disabling, upgrading, reloading and deleting plugins.
Does this PR introduce a user-facing change?