Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update chinese display name of post editor role #5224

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 22, 2024

What type of PR is this?

/area core
/milestone 2.12.x

What this PR does / why we need it:

修改文章编辑角色的显示名称为文章管理员,这样会更加直观。

Which issue(s) this PR fixes:

Fixes #5221

Does this PR introduce a user-facing change?

修改文章编辑角色的显示名称为**文章管理员**。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Jan 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen January 22, 2024 06:17
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14580b9) 57.06% compared to head (5087dab) 57.06%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5224   +/-   ##
=========================================
  Coverage     57.06%   57.06%           
  Complexity     3333     3333           
=========================================
  Files           584      584           
  Lines         19190    19190           
  Branches       1444     1444           
=========================================
  Hits          10950    10950           
  Misses         7664     7664           
  Partials        576      576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
Copy link

f2c-ci-robot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 95878b3 into halo-dev:main Jan 22, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议将“编辑者”角色改名为“文章管理员”
2 participants