Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: add additional attributes and colgroup for tables #5176

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jan 11, 2024

What type of PR is this?

/kind improvmenet
/area editor
/milestone 2.12.x

What this PR does / why we need it:

为默认编辑器 table 组件渲染后的结果中增加 colgroup,并为 table 增加 widthminWidth 属性。
用于解决渲染完成之后的 table html 宽度与编辑时不一致的问题。

How to test it?

拖拽修改默认编辑器表格列宽,查看生成后的 html 列宽是否同样发生了变化,并且查看生成的 html 结构下是否具有 colgroup html 元素。

Which issue(s) this PR fixes:

Fixes #5138

Does this PR introduce a user-facing change?

为默认富文本编辑器 table 组件渲染后的 html 增加 colgroup 元素与 width 属性

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/editor Issues or PRs related to the Editor labels Jan 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 11, 2024
Copy link

f2c-ci-robot bot commented Jan 11, 2024

@LIlGG: The label(s) kind/improvmenet cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind improvmenet
/area editor
/milestone 2.12.x

What this PR does / why we need it:

为默认编辑器 table 组件渲染后的结果中增加 colgroup,并为 table 增加 widthminWidth 属性。
用于解决渲染完成之后的 table html 宽度与编辑时不一致的问题。

How to test it?

拖拽修改默认编辑器表格列宽,查看生成后的 html 列宽是否同样发生了变化,并且查看生成的 html 结构下是否具有 colgroup html 元素。

Which issue(s) this PR fixes:

Fixes #5138

Does this PR introduce a user-facing change?

为默认富文本编辑器 table 组件渲染后的 html 增加 colgroup 元素与 width 属性

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and wzrove January 11, 2024 06:46
@LIlGG
Copy link
Member Author

LIlGG commented Jan 11, 2024

/hold 需要等待 #5173 合并

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Jan 11, 2024

createColGroup 包并没有包含在 tiptap 2.1.x 版本包中,因此需要等待 tiptap 发布 2.2.x 版本后。

@JohnNiang
Copy link
Member

createColGroup 包并没有包含在 tiptap 2.1.x 版本包中,因此需要等待 tiptap 发布 2.2.x 版本后。

可以考虑升级至 https://github.com/ueberdosis/tiptap/releases/tag/v2.2.0-rc.8

@LIlGG LIlGG changed the title WIP: pref: add additional attributes and colgroup for tables pref: add additional attributes and colgroup for tables Jan 12, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Jan 12, 2024

/unhold 已使用 https://github.com/ueberdosis/tiptap/releases/tag/v2.2.0-rc.8 替代

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. chrome 上发现一个 console 表格没有横向滚动条的问题,导致表格展示不全
image 2. 对于上述问题在主题端表现是表格溢出 image

@guqing
Copy link
Member

guqing commented Jan 12, 2024

滚动问题可能和这个 issue 有关 #5182,帮忙确认不是此 pr 的问题

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b050e29) 56.47% compared to head (97a4c08) 56.47%.
Report is 8 commits behind head on main.

❗ Current head 97a4c08 differs from pull request most recent head 6a892d7. Consider uploading reports for the commit 6a892d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5176   +/-   ##
=========================================
  Coverage     56.47%   56.47%           
  Complexity     3003     3003           
=========================================
  Files           525      525           
  Lines         17614    17614           
  Branches       1304     1304           
=========================================
  Hits           9948     9948           
  Misses         7126     7126           
  Partials        540      540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG
Copy link
Member Author

LIlGG commented Jan 15, 2024

  1. chrome 上发现一个 console 表格没有横向滚动条的问题,导致表格展示不全

console 端滚动问题将在 #5182 中进行解决。

  1. 对于上述问题在主题端表现是表格溢出

已经提交新的 commit 修复此问题。

@LIlGG LIlGG requested a review from guqing January 15, 2024 09:05
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

/lgtm

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
Copy link

f2c-ci-robot bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit b42e046 into halo-dev:main Jan 18, 2024
7 checks passed
LIlGG added a commit to LIlGG/halo that referenced this pull request Jan 19, 2024
/kind improvmenet
/area editor
/milestone 2.12.x

为默认编辑器 table 组件渲染后的结果中增加 `colgroup`,并为 table 增加 `width` 与 `minWidth` 属性。
用于解决渲染完成之后的 table html 宽度与编辑时不一致的问题。

拖拽修改默认编辑器表格列宽,查看生成后的 html 列宽是否同样发生了变化,并且查看生成的 html 结构下是否具有 `colgroup` html 元素。

Fixes halo-dev#5138

```release-note
为默认富文本编辑器 table 组件渲染后的 html 增加 colgroup 元素与 width 属性
```

feat: add search and replace

feat: add search and replace

feat: add search and replace

feat: add search and replace

feat: add search and replace

feat: add search and replace
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 19, 2024
@LIlGG LIlGG deleted the pref/render-table-colgroup branch February 1, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认富文本编辑器的表格列宽显示问题
4 participants