Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address styling issues with empty lines in code blocks #5140

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jan 2, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

修改 code 内br 标签的 display,用于适配 firefox 浏览器

How to test it?

测试在 firefox 浏览器下,使用代码块回车等是否会出现样式问题。

Which issue(s) this PR fixes:

Fixes #5064

Does this PR introduce a user-facing change?

解决在 Firefox 浏览器下的代码块编辑问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 2, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby January 2, 2024 09:08
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a51c5d) 55.91% compared to head (7cc6c2c) 55.91%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5140   +/-   ##
=========================================
  Coverage     55.91%   55.91%           
  Complexity     3032     3032           
=========================================
  Files           524      524           
  Lines         17826    17826           
  Branches       1329     1329           
=========================================
  Hits           9968     9968           
  Misses         7309     7309           
  Partials        549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox 下工作正常。

图片

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
Copy link

f2c-ci-robot bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@ruibaby
Copy link
Member

ruibaby commented Jan 2, 2024

/milestone 2.12.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 2, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 694ad26 into halo-dev:main Jan 2, 2024
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using Firefox browser, pressing Enter key in the editor code block cannot return a newline properly
4 participants