Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add vue dev tools #5134

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 30, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.12.x

What this PR does / why we need it:

为 Console 和 UC 添加 Vue 社区新的 Dev Tools

可以不再需要依赖浏览器插件。

图片 图片

Special notes for your reviewer:

后续也可以尝试为 Halo 的 UI 部分的插件机制适配 Dev Tools,参考:https://devtools-next.vuejs.org/plugins/api

Does this PR introduce a user-facing change?

为 Console 和 UC 添加 Vue 社区新的 [Dev Tools](https://github.com/vuejs/devtools-next)。

Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/console Issues or PRs related to the Halo Console labels Dec 30, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Dec 30, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Dec 30, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing December 30, 2023 15:17
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82d2afc) 57.07% compared to head (6ace5b1) 57.07%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5134   +/-   ##
=========================================
  Coverage     57.07%   57.07%           
  Complexity     3327     3327           
=========================================
  Files           587      587           
  Lines         18958    18958           
  Branches       1400     1400           
=========================================
  Hits          10821    10821           
  Misses         7558     7558           
  Partials        579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
@guqing
Copy link
Member

guqing commented Jan 2, 2024

用起来会影响到页面的速度,在我电脑上切换一个菜单都卡老半天 感觉非常影响使用 暂时不合并吧
/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2024
@ruibaby ruibaby removed this from the 2.12.x milestone Jan 22, 2024
Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
@ruibaby
Copy link
Member Author

ruibaby commented Jan 29, 2024

用起来会影响到页面的速度,在我电脑上切换一个菜单都卡老半天 感觉非常影响使用 暂时不合并吧 /hold

已升级版本,目前最新版本 7.0.13 已经不会再出现此问题。

@guqing
Copy link
Member

guqing commented Jan 29, 2024

/unhold

@f2c-ci-robot f2c-ci-robot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 29, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link

f2c-ci-robot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 9137d50 into halo-dev:main Jan 29, 2024
7 checks passed
@ruibaby ruibaby deleted the chore/vue-dev-tools branch January 29, 2024 08:55
@ruibaby ruibaby added this to the 2.12.0 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants