Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getParentByChildrenName method to CategoryFinder interface #4980

Closed
wants to merge 0 commits into from

Conversation

Roozenlz
Copy link
Contributor

@Roozenlz Roozenlz commented Dec 3, 2023

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

add getParentByChildrenName method to CategoryFinder interface

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

${categoryFinder.getParentByChildrenName(anyChild.metadata.name)}

Does this PR introduce a user-facing change?

NONE

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Dec 3, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby December 3, 2023 05:34
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @halo-dev/sig-halo

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (551f2ae) 55.94% compared to head (6058e1e) 55.93%.
Report is 2 commits behind head on main.

Files Patch % Lines
...alo/app/theme/finders/impl/CategoryFinderImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4980      +/-   ##
============================================
- Coverage     55.94%   55.93%   -0.02%     
  Complexity     3034     3034              
============================================
  Files           525      525              
  Lines         17816    17820       +4     
  Branches       1329     1329              
============================================
  Hits           9967     9967              
- Misses         7300     7304       +4     
  Partials        549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -28,4 +28,6 @@ public interface CategoryFinder {
Flux<CategoryTreeVo> listAsTree();

Flux<CategoryTreeVo> listAsTree(String name);

Mono<CategoryVo> getParentByChildrenName(String name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉直接叫 getParentByName 即可。

Copy link

f2c-ci-robot bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang
Copy link
Member

Hi @Roozenlz ,关闭当前 PR 的原因是什么呢?如果想要修改源码,只需要持续向当前分支 commit & push 即可。可参考 https://docs.halo.run/contribution/pr

@Roozenlz
Copy link
Contributor Author

Roozenlz commented Dec 6, 2023

Hi @Roozenlz ,关闭当前 PR 的原因是什么呢?如果想要修改源码,只需要持续向当前分支 commit & push 即可。可参考 https://docs.halo.run/contribution/pr。

误操作了,现在提交的commit需要重新提交pr了,有什么办法吗

@JohnNiang
Copy link
Member

Hi @Roozenlz ,我们暂时以 #5002 为准。如果有进一步的 commit,可以直接向对应的分支 commit & push。

@JohnNiang JohnNiang added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants