-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getParentByChildrenName method to CategoryFinder interface #4980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ping @halo-dev/sig-halo
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4980 +/- ##
============================================
- Coverage 55.94% 55.93% -0.02%
Complexity 3034 3034
============================================
Files 525 525
Lines 17816 17820 +4
Branches 1329 1329
============================================
Hits 9967 9967
- Misses 7300 7304 +4
Partials 549 549 ☔ View full report in Codecov by Sentry. |
@@ -28,4 +28,6 @@ public interface CategoryFinder { | |||
Flux<CategoryTreeVo> listAsTree(); | |||
|
|||
Flux<CategoryTreeVo> listAsTree(String name); | |||
|
|||
Mono<CategoryVo> getParentByChildrenName(String name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉直接叫 getParentByName 即可。
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Roozenlz ,关闭当前 PR 的原因是什么呢?如果想要修改源码,只需要持续向当前分支 commit & push 即可。可参考 https://docs.halo.run/contribution/pr。 |
误操作了,现在提交的commit需要重新提交pr了,有什么办法吗 |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
add getParentByChildrenName method to CategoryFinder interface
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
${categoryFinder.getParentByChildrenName(anyChild.metadata.name)}
Does this PR introduce a user-facing change?