Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use storybook to refactor components library docs #4944

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

pillar-cat
Copy link
Contributor

@pillar-cat pillar-cat commented Nov 29, 2023

What type of PR is this?

/kind feature
/area console
/milestone 2.8.x

What this PR does / why we need it:

Console Components使用StoryBook代替Histories

Which issue(s) this PR fixes:

Fixes #4117

Special notes for your reviewer:

  1. 移动到 console/packages/components 目录。
  2. pnpm storybook

Does this PR introduce a user-facing change?

使用 Storybook 重构 `@halo-dev/components` 文档。

Copy link

f2c-ci-robot bot commented Nov 29, 2023

@pillar-cat: You must be a member of the halo-dev/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

What type of PR is this?

/kind feature
/area console
/milestone 2.8.x

What this PR does / why we need it:

Console Components使用StoryBook代替Histories

Which issue(s) this PR fixes:

Fixes #4117

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. area/console Issues or PRs related to the Halo Console labels Nov 29, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby November 29, 2023 13:24
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
All committers have signed the CLA.

@pillar-cat pillar-cat changed the title Storybook component feat: console components migration to storybook from histories Nov 29, 2023
@JohnNiang
Copy link
Member

Hi @pillar-cat ,在 Review 之前需要先解决一下冲突。

@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (197c622) 55.94% compared to head (9773ca4) 55.94%.

❗ Current head 9773ca4 differs from pull request most recent head a06d9ce. Consider uploading reports for the commit a06d9ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4944   +/-   ##
=========================================
  Coverage     55.94%   55.94%           
  Complexity     3034     3034           
=========================================
  Files           525      525           
  Lines         17816    17816           
  Branches       1329     1329           
=========================================
  Hits           9967     9967           
  Misses         7300     7300           
  Partials        549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Wang <[email protected]>
@ruibaby ruibaby changed the title feat: console components migration to storybook from histories feat: use storybook to refactor components library docs Dec 4, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 4, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

图片

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

cc @halo-dev/sig-halo-console

Copy link

f2c-ci-robot bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 5b5fe71 into halo-dev:main Dec 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用 Storybook 重构 Console 组件库的文档
5 participants