Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot change the user's own avatar #4777

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Oct 27, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

当前用户上传头像时的接口中名字应该是 - 而不是具体的 metadata name。

How to test it?

使用无用户管理权限的用户登录,查看是否能上传头像。

Which issue(s) this PR fixes:

Fixes #4776

Does this PR introduce a user-facing change?

解决无用户管理权限的用户无法上传头像的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 27, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and wzrove October 27, 2023 08:20
@LIlGG
Copy link
Member Author

LIlGG commented Oct 27, 2023

/milestone 2.11.x
/cherry-pick release-2.10

@halo-dev-bot
Copy link
Collaborator

@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/milestone 2.11.x
/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #4777 (f90c0f8) into main (2dbfbd1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4777   +/-   ##
=========================================
  Coverage     61.50%   61.50%           
  Complexity     2798     2798           
=========================================
  Files           403      403           
  Lines         14772    14772           
  Branches       1029     1029           
=========================================
  Hits           9086     9086           
  Misses         5193     5193           
  Partials        493      493           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ruibaby
Copy link
Member

ruibaby commented Oct 27, 2023

/cherrypick release-2.10

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 921518a into halo-dev:main Oct 27, 2023
2 checks passed
@halo-dev-bot
Copy link
Collaborator

@LIlGG: new pull request created: #4778

In response to this:

/milestone 2.11.x
/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Oct 27, 2023
This is an automated cherry-pick of #4777

/assign LIlGG

```release-note
解决无用户管理权限的用户无法上传头像的问题
```
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

没有用户管理权限的用户无法修改头像
4 participants