-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use new api to change plugin status #4747
refactor: use new api to change plugin status #4747
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4747 +/- ##
============================================
- Coverage 61.50% 61.50% -0.01%
Complexity 2798 2798
============================================
Files 403 403
Lines 14770 14772 +2
Branches 1028 1029 +1
============================================
+ Hits 9085 9086 +1
Misses 5193 5193
- Partials 492 493 +1 |
Signed-off-by: Ryan Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
console/packages/api-client/src/models/plugin-motion-status-request.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind improvement
What this PR does / why we need it:
适配 #4745 ,使用新的接口启动/停止插件。
Which issue(s) this PR fixes:
Fixes #4744
Special notes for your reviewer:
Does this PR introduce a user-facing change?