Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use new api to change plugin status #4747

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 18, 2023

What type of PR is this?

/area console
/kind improvement

What this PR does / why we need it:

适配 #4745 ,使用新的接口启动/停止插件。

Which issue(s) this PR fixes:

Fixes #4744

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 18, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove October 18, 2023 07:42
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #4747 (32bb18d) into main (772c7fc) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4747      +/-   ##
============================================
- Coverage     61.50%   61.50%   -0.01%     
  Complexity     2798     2798              
============================================
  Files           403      403              
  Lines         14770    14772       +2     
  Branches       1028     1029       +1     
============================================
+ Hits           9085     9086       +1     
  Misses         5193     5193              
- Partials        492      493       +1     

see 1 file with indirect coverage changes

@ruibaby ruibaby added this to the 2.11.x milestone Oct 19, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit e20ab8f into halo-dev:main Oct 26, 2023
2 checks passed
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Oct 31, 2023
@ruibaby ruibaby deleted the refactor/change-plugin-status-2 branch November 18, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望后端提供插件启动和停止的 APIs 以简化前端启动插件的复杂度
3 participants