-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant users path for PAT endpoint #4662
Conversation
ee951ae
to
7db00d1
Compare
单元测试未通过 Fixed. See 7db00d1#diff-0d86294cf8e35c2d422cba4aab0a04de288430765ee751748d324cc0bb849562 for more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Codecov Report
@@ Coverage Diff @@
## main #4662 +/- ##
============================================
+ Coverage 60.98% 61.02% +0.04%
Complexity 2610 2610
============================================
Files 378 378
Lines 13551 13541 -10
Branches 959 958 -1
============================================
Hits 8264 8264
+ Misses 4822 4812 -10
Partials 465 465
|
What type of PR is this?
/kind improvement
/kind api-change
/area core
What this PR does / why we need it:
This PR refines route paths created from #4598. Because the user scope is not necessary here.
Special notes for your reviewer:
Try to manage your PATs.
Does this PR introduce a user-facing change?