Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant users path for PAT endpoint #4662

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/kind api-change
/area core

What this PR does / why we need it:

This PR refines route paths created from #4598. Because the user scope is not necessary here.

Special notes for your reviewer:

Try to manage your PATs.

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/core Issues or PRs related to the Halo Core labels Sep 26, 2023
@guqing
Copy link
Member

guqing commented Sep 26, 2023

image

单元测试未通过

@JohnNiang JohnNiang force-pushed the refactor/pat-endpoint branch from ee951ae to 7db00d1 Compare September 26, 2023 07:19
@JohnNiang
Copy link
Member Author

image 单元测试未通过

Fixed. See 7db00d1#diff-0d86294cf8e35c2d422cba4aab0a04de288430765ee751748d324cc0bb849562 for more.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2023

New changes are detected. LGTM label has been removed.

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@ruibaby ruibaby added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4662 (82b2b63) into main (97c92d0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4662      +/-   ##
============================================
+ Coverage     60.98%   61.02%   +0.04%     
  Complexity     2610     2610              
============================================
  Files           378      378              
  Lines         13551    13541      -10     
  Branches        959      958       -1     
============================================
  Hits           8264     8264              
+ Misses         4822     4812      -10     
  Partials        465      465              
Files Coverage Δ
...o/app/security/authentication/pat/PatEndpoint.java 100.00% <100.00%> (ø)
...hentication/pat/impl/UserScopedPatHandlerImpl.java 52.85% <ø> (+3.52%) ⬆️

@f2c-ci-robot f2c-ci-robot bot merged commit a5a6978 into halo-dev:main Sep 26, 2023
2 checks passed
@JohnNiang JohnNiang deleted the refactor/pat-endpoint branch September 26, 2023 08:33
@ruibaby ruibaby added this to the 2.10.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants